Fix Err fallout for graph/iterator.Materialize iterator

This commit is contained in:
Andrew Dunham 2015-04-15 10:48:50 -07:00
parent 0148f6ef12
commit 912b126e92
2 changed files with 89 additions and 2 deletions

View file

@ -48,6 +48,7 @@ type Materialize struct {
subIt graph.Iterator
hasRun bool
aborted bool
err error
runstats graph.IteratorStats
}
@ -108,6 +109,7 @@ func (it *Materialize) Clone() graph.Iterator {
if it.hasRun {
out.hasRun = true
out.aborted = it.aborted
out.err = it.err
out.values = it.values
out.containsMap = it.containsMap
out.actualSize = it.actualSize
@ -199,8 +201,15 @@ func (it *Materialize) Next() bool {
if !it.hasRun {
it.materializeSet()
}
if it.err != nil {
return false
}
if it.aborted {
return graph.Next(it.subIt)
n := graph.Next(it.subIt)
if err := graph.Err(it.subIt); err != nil {
it.err = err
}
return n
}
it.index++
@ -211,6 +220,10 @@ func (it *Materialize) Next() bool {
return graph.NextLogOut(it, it.Result(), true)
}
func (it *Materialize) Err() error {
return it.err
}
func (it *Materialize) Contains(v graph.Value) bool {
graph.ContainsLogIn(it, v)
it.runstats.Contains += 1
@ -283,7 +296,9 @@ func (it *Materialize) materializeSet() {
it.actualSize += 1
}
}
if it.aborted {
if err := graph.Err(it.subIt); err != nil {
it.err = err
} else if it.aborted {
if glog.V(2) {
glog.V(2).Infoln("Aborting subiterator")
}