barak/cayley
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Fix NPEs in SQL Next and Contains

Browse source
This commit is contained in:
Quentin Machu 2015-08-26 01:19:28 -04:00
parent ebaf8b2a98
commit 7ddeb101ca
2 changed files with 11 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
graph/sql/all_iterator.go
View file

@ -131,6 +131,9 @@ func (it *AllIterator) Next() bool {
graph.NextLogIn(it)
if it.cursor == nil {
it.makeCursor()
if it.cursor == nil {
return false
}
}
if !it.cursor.Next() {
glog.V(4).Infoln("sql: No next")

7
graph/sql/sql_iterator.go
View file

@ -151,6 +151,11 @@ func (it *SQLIterator) Next() bool {
graph.NextLogIn(it)
if it.cursor == nil {
err = it.makeCursor(true, nil)
if err != nil {
glog.Errorf("Couldn't make query: %v", err)
it.err = err
return false
}
it.cols, err = it.cursor.Columns()
if err != nil {
glog.Errorf("Couldn't get columns")
@ -226,7 +231,9 @@ func (it *SQLIterator) Contains(v graph.Value) bool {
if err != nil {
glog.Errorf("Couldn't make query: %v", err)
it.err = err
if it.cursor != nil {
it.cursor.Close()
}
return false
}
it.cols, err = it.cursor.Columns()