barak/cayley
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Fixes memstore transaction semantics

Browse source
This commit is contained in:
Barak Michener 2015-09-02 17:36:00 -04:00
parent b8b3e1b45a
commit 3e2b490063
2 changed files with 51 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

22
graph/memstore/quadstore.go
View file

@ -106,6 +106,26 @@ func newQuadStore() *QuadStore {
}
func (qs *QuadStore) ApplyDeltas(deltas []graph.Delta, ignoreOpts graph.IgnoreOpts) error {
// Precheck the whole transaction
for _, d := range deltas {
switch d.Action {
case graph.Add:
if !ignoreOpts.IgnoreDup {
if _, exists := qs.indexOf(d.Quad); exists {
return graph.ErrQuadExists
}
}
case graph.Delete:
if !ignoreOpts.IgnoreMissing {
if _, exists := qs.indexOf(d.Quad); !exists {
return graph.ErrQuadNotExist
}
}
default:
return errors.New("memstore: invalid action")
}
}
for _, d := range deltas {
var err error
switch d.Action {
@ -120,7 +140,7 @@ func (qs *QuadStore) ApplyDeltas(deltas []graph.Delta, ignoreOpts graph.IgnoreOp
err = nil
}
default:
err = errors.New("memstore: invalid action")
panic("memstore: unexpected invalid action")
}
if err != nil {
return err