barak/cayley
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Clean up residual changes

Browse source 
Remove done TODOs and unnecessary helpers.
This commit is contained in:
kortschak 2014-08-05 23:27:13 +09:30
parent 6acfdcc5d6
commit 2c6f0f7345
8 changed files with 129 additions and 136 deletions
Download patch file Download diff file Expand all files Collapse all files

11
quad/quad.go
View file

@ -100,9 +100,6 @@ func (d Direction) String() string {
}
}
// TODO(kortschak) Consider writing methods onto the concrete type
// instead of the pointer. This needs benchmarking to make the decision.
// Per-field accessor for triples
func (q Quad) Get(d Direction) string {
switch d {
@ -119,10 +116,6 @@ func (q Quad) Get(d Direction) string {
}
}
func (q Quad) Equals(o Quad) bool {
return q == o
}
// Pretty-prints a triple.
func (q Quad) String() string {
return fmt.Sprintf("%s -- %s -> %s", q.Subject, q.Predicate, q.Object)
@ -132,10 +125,6 @@ func (q Quad) IsValid() bool {
return q.Subject != "" && q.Predicate != "" && q.Object != ""
}
// TODO(kortschak) NTriple looks like a good candidate for conversion
// to MarshalText() (text []byte, err error) and then move parsing code
// from nquads to here to provide UnmarshalText(text []byte) error.
// Prints a triple in N-Quad format.
func (q Quad) NTriple() string {
if q.Label == "" {