From 13b11e46a4e2fac36f86b697b8bed9fab65cca58 Mon Sep 17 00:00:00 2001 From: Quentin Machu Date: Wed, 26 Aug 2015 02:10:27 -0400 Subject: [PATCH] Make the SQL connection fail-fast --- graph/sql/quadstore.go | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/graph/sql/quadstore.go b/graph/sql/quadstore.go index 65b25fe..d7f3a87 100644 --- a/graph/sql/quadstore.go +++ b/graph/sql/quadstore.go @@ -44,6 +44,13 @@ func connectSQLTables(addr string, _ graph.Options) (*sql.DB, error) { glog.Errorf("Couldn't open database at %s: %#v", addr, err) return nil, err } + // "Open may just validate its arguments without creating a connection to the database." + // "To verify that the data source name is valid, call Ping." + // Source: http://golang.org/pkg/database/sql/#Open + if err := conn.Ping(); err != nil { + glog.Errorf("Couldn't open database at %s: %#v", addr, err) + return nil, err + } return conn, nil }